JS bindings for entropy client #897
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ameba23
commented
Jun 19, 2024
| @@ -103,3 +103,10 @@ pub enum ClientError { | |||
| #[error("Verifying key has incorrect length")] | |||
| BadVerifyingKeyLength, | |||
| } | |||
|
|
|||
| #[cfg(feature = "full-client")] | |||
There was a problem hiding this comment.
For some reason when compiling for wasm it doesn't like me deriving this trait with thiserror for this particular error type.
* Minor grammatical and spelling updates. * Fixed SDK NPM link.
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
Entropy-Machine-CI
added a commit
to entropyxyz/.github
that referenced
this pull request
Jul 30, 2024
|
I have read the CLA Document and I hereby sign the CLA |
Entropy-Machine-CI
added a commit
to entropyxyz/.github
that referenced
this pull request
Jul 30, 2024
|
Closing this as it seems no-one wants it. Can re-open if that changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds JS bindings to entropy-client.
The idea is to make it easier to migrate the SDK to a newer version of
entropy-core- as this binds to client code which is all tested in CI inentropy-core. And also to avoid issues with inconsistencies between subxt and polkadot JS - by relying less on polkadot JS.There is a very basic nodejs test CLI for trying this out
For some reason when using docker-compose i have to specify the chain endpoint as
ws://127.0.0.1:9944- it does not likelocalhost(gives a connection refused error).Register is a bit complicated because to poll for registration we need to a way to 'sleep' - rusts
std::thread::sleepdoesn't work. Theweb-syscrate does gives us access towindow.setTimeout()but i think i prefer to keep this out of our bindings.So i split registration into 2 functions. One which submits the transaction and one which checks for a confirmation with a given account id and returns the verifying key if successful. Running the loop and adding a delay is done externally in JS.
I am occasionally seeing this issue: #542 - which does not effect things working, but means an annoying error message pops up.
Tested manually with nodejs 18.15.0.
I am not planning to add tests for this because of the issues we had with the JS tests for entropy-protocol. If it this gets used in the SDK it should be tested there, and if it does not get used in the SDK then we probably dont need these bindings.