Fix: support more vcs-type fields in module creation #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerHeber
commented
Jan 24, 2025
| @@ -43,7 +46,10 @@ type ModuleCreatePayload struct { | |||
| TokenName string `json:"tokenName,omitempty"` | |||
| GithubInstallationId *int `json:"githubInstallationId,omitempty"` | |||
| BitbucketClientKey string `json:"bitbucketClientKey,omitempty"` | |||
| IsGitlab *bool `json:"isGitLab,omitempty"` | |||
| IsGitlab bool `json:"isGitLab"` | |||
There was a problem hiding this comment.
default is false. Not sure why this was ever a pointer.
TomerHeber
commented
Jan 24, 2025
| @@ -12,12 +12,6 @@ import ( | |||
| ) | |||
|
|
|||
| func resourceModule() *schema.Resource { | |||
| vcsExactlyOneOf := []string{ | |||
There was a problem hiding this comment.
using conflictsWith instead.
Due to this comment:
when isGitLabEnterprise is true the token_id and token_name should not be required
|
/review |
github-actions
bot
added
ready to merge
| @@ -119,6 +113,30 @@ func resourceModule() *schema.Resource { | |||
| Optional: true, | |||
| Default: false, | |||
| }, | |||
| "is_gitlab": { | |||
There was a problem hiding this comment.
why not using conflictsWith for these as well?
GL can't be BBS for example, seems like a good validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue & Steps to Reproduce / Feature Request
fixes #1002
fixes #1004
Solution