Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HTTP client retry mechanism #877

Closed
yaronya opened this issue Jun 18, 2024 · 1 comment · Fixed by #884
Closed

Fix HTTP client retry mechanism #877

yaronya opened this issue Jun 18, 2024 · 1 comment · Fixed by #884
Assignees
Labels
api-client bug Something isn't working

Comments

@yaronya
Copy link
Contributor

yaronya commented Jun 18, 2024

We recently experienced flakiness in the 029_provider harness test where consecutive call to get the recently created provider fails (see test_provider_data data resource that was commented out in #876)

I explicitly tried to search for the log of Received a failed or not found response, retrying request as specified here but couldn't find it in the log - meaning that it might not work

We should fix it and validate that it indeed works. We could validate it with:

  1. Manually create a provider (or any other resource) @ env0
  2. Manually remove it
  3. Configure a data resource against it - and see whether http client retries or not (with validating that the actual log is printed)

Please note to undo the changes of #876 too.

@yaronya yaronya added bug Something isn't working api-client labels Jun 18, 2024
@TomerHeber
Copy link
Collaborator

@yaronya

Generally retry will occur if INTEGRATION_TESTS environment variable is set to 1.
Is that the case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-client bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants