Fix: "all_teams" data resource causes 429 status code requests #988
Conversation
|
/review |
| @@ -309,7 +308,7 @@ func TestConfigurationVariableMarshelling(t *testing.T) { | |||
|
|
|||
| b, err := json.Marshal(&variable) | |||
| if assert.NoError(t, err) { | |||
| assert.False(t, strings.Contains(string(b), str)) | |||
| assert.NotContains(t, string(b), str) | |||
There was a problem hiding this comment.
linter complaints...
| @@ -0,0 +1,22 @@ | |||
| package client | |||
There was a problem hiding this comment.
generic memoization function.
| @@ -11,6 +11,7 @@ import ( | |||
| func dataTeams() *schema.Resource { | |||
| return &schema.Resource{ | |||
| ReadContext: dataTeamsRead, | |||
| Description: "Note: this data source is cached, once fetched it will not be updated until the next plan/apply", | |||
There was a problem hiding this comment.
added this note so users understand limitations.
It's already covered by some tests (acceptance and harness). |
@TomerHeber I'd like the memoization to be tested at least. to see it doesn't invoke the same call twice for the same parameters, does call for different parameters |
|
Got it. Makes sense. |
|
@sagilaufer1992 - added the unit tests for memoization. |
github-actions
bot
added
the
ready to merge
Issue & Steps to Reproduce / Feature Request
fixes #987
Solution
Added memorization to the get teams call.
This caches results between terraform executions.
The downside is that the results will be stale during the execution.