Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix typos #996

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Fix: fix typos #996

merged 1 commit into from
Dec 19, 2024

Conversation

szepeviktor
Copy link

Solution

Found few misspellings.
Many bombs were defused 💣

Please use https://github.com/crate-ci/typos at Env0

@TomerHeber TomerHeber changed the title Fix typos Fix: fix typos Dec 19, 2024
@TomerHeber TomerHeber closed this Dec 19, 2024
@szepeviktor
Copy link
Author

@TomerHeber Not interested in these changes?

@szepeviktor
Copy link
Author

szepeviktor commented Dec 19, 2024

CI fails because secrets are not available to PRs from forks.

env:
ENV0_API_ENDPOINT: ${{ secrets.ENV0_API_ENDPOINT }}
ENV0_API_KEY: ${{ secrets.TF_PROVIDER_INTEGRATION_TEST_API_KEY }} # API Key for organization 'TF-provider-integration-tests' @ dev
ENV0_API_SECRET: ${{ secrets.TF_PROVIDER_INTEGRATION_TEST_API_SECRET }}

@TomerHeber
Copy link
Collaborator

TomerHeber commented Dec 19, 2024

Hi @szepeviktor -

Thank you for the PR. (I closed it by mistake).

I am very interested in this fix.
However, I need to figure out how I can get the pipelines to the path from the remote branch.

@TomerHeber TomerHeber reopened this Dec 19, 2024
@TomerHeber TomerHeber self-assigned this Dec 19, 2024
@TomerHeber TomerHeber changed the base branch from main to fix-typos December 19, 2024 23:35
@TomerHeber TomerHeber merged commit 1b40f38 into env0:fix-typos Dec 19, 2024
2 of 5 checks passed
@szepeviktor szepeviktor deleted the typos branch December 20, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants