Feat: add support for update credentials #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerHeber
commented
Sep 13, 2023
| @@ -8,7 +8,7 @@ env: | |||
| ENV0_API_ENDPOINT: ${{ secrets.ENV0_API_ENDPOINT }} | |||
| ENV0_API_KEY: ${{ secrets.TF_PROVIDER_INTEGRATION_TEST_API_KEY }} # API Key for organization 'TF-provider-integration-tests' @ dev | |||
| ENV0_API_SECRET: ${{ secrets.TF_PROVIDER_INTEGRATION_TEST_API_SECRET }} | |||
| GO_VERSION: 1.19 | |||
| GO_VERSION: "1.20" | |||
There was a problem hiding this comment.
had to add quotes. There's a bug/issue if this isn't done. (Will use go 1.2).
TomerHeber
commented
Sep 13, 2023
| - name: Generate mocks | ||
| run: | | ||
| go install github.com/golang/mock/[email protected] |
There was a problem hiding this comment.
This has been deprecated. Ownership moved to Uber.
TomerHeber
commented
Sep 13, 2023
| @@ -143,10 +143,27 @@ func (client *ApiClient) CredentialsCreate(request CredentialCreatePayload) (Cre | |||
| request.SetOrganizationId(organizationId) | |||
|
|
|||
| var result Credentials | |||
| err = client.http.Post("/credentials", request, &result) | |||
| if err := client.http.Post("/credentials", request, &result); err != nil { | |||
There was a problem hiding this comment.
github diff mixup... this did not change other than this line.
TomerHeber
commented
Sep 13, 2023
| return result, nil | ||
| } | ||
|
|
||
| func (client *ApiClient) CredentialsUpdate(id string, request CredentialCreatePayload) (Credentials, error) { |
There was a problem hiding this comment.
this is all new
TomerHeber
commented
Sep 13, 2023
| @@ -115,6 +115,46 @@ var _ = Describe("CloudCredentials", func() { | |||
| }) | |||
| }) | |||
|
|
|||
| Describe("AwsCredentialsUpdate", func() { | |||
There was a problem hiding this comment.
unit test for the new update API.
TomerHeber
commented
Sep 13, 2023
| @@ -2,7 +2,6 @@ package env0 | |||
|
|
|||
There was a problem hiding this comment.
This code has been refactored. Easier to support the Update use-case without duplicating code.
There was a problem hiding this comment.
might be easier to just review the whole file.
Wassap124
reviewed
Sep 18, 2023
Wassap124
approved these changes
Sep 18, 2023
github-actions
bot
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue & Steps to Reproduce / Feature Request
Resolves #678
Solution
Part of this PR was upgrading to go 1.20 and replace gomock location (original project has been deprecated).
I have also updated github action versions. Therefore, "87" files are changed.
Some guidelines for reviewing this PR: