Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add support for Duration for AWS Assume Roles in env0_aws_crede… #711

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Feat: add support for Duration for AWS Assume Roles in env0_aws_crede… #711

merged 3 commits into from
Sep 27, 2023

Conversation

TomerHeber
Copy link
Collaborator

…ntials resource

Issue & Steps to Reproduce / Feature Request

resolves #710

Solution

  1. Updated the schema.
  2. Updated the API.
  3. Updated the unit, acceptance and integration tests.

@TomerHeber TomerHeber self-assigned this Sep 19, 2023
sagilaufer1992
sagilaufer1992 reviewed Sep 21, 2023
View reviewed changes
Copy link
Contributor

@sagilaufer1992 sagilaufer1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Have some comments about the tests.

client/cloud_credentials_test.go Show resolved Hide resolved
env0/resource_cost_credentials_test.go Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see only test that is updated with duration.
Can you test also creation with duration please?
And also create and update with illegal values?

If these cases are tested somewhere else please point me there

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to add these.
I'll do it a bit later today.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sagilaufer1992 sorry for the delay.
I have added the requested use-cases.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sagilaufer1992
sagilaufer1992 approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@sagilaufer1992 sagilaufer1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cases added as requested in other comment

@github-actions github-actions bot added ready to merge PR approved - can be merged once the PR owner is ready and removed pending final review labels Sep 27, 2023
@TomerHeber TomerHeber merged commit f3ad458 into main Sep 27, 2023
6 checks passed
@TomerHeber TomerHeber deleted the feat-add-support-for-duration-#710 branch September 27, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagilaufer1992 sagilaufer1992 sagilaufer1992 approved these changes

Assignees

@TomerHeber TomerHeber

Labels
api-client feature integration-tests provider ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Duration for AWS Assume Roles in env0_aws_credentials resource
2 participants
@TomerHeber @sagilaufer1992