Feat: add new OIDC credentials creation and assigment (vault) #783
Conversation
|
|
||
| provider "env0" {} | ||
|
|
||
| variable "second_run" { |
There was a problem hiding this comment.
why do we need this variable?
There was a problem hiding this comment.
I actually want to use it to test updates.
But hadn't applied it to the test. Adding it now.
There was a problem hiding this comment.
See this is an example:
eef71ed
There was a problem hiding this comment.
it looks like we have some failing tests
There was a problem hiding this comment.
once you fix those you are good to go
There was a problem hiding this comment.
yeah I just found out update was never tested.
I'm adding the tests, and fixing the cause for it failing.
I'll push once the tests path. Thanks!
There was a problem hiding this comment.
never tested not just for OIDC... but all AWS, GCP and Azure for all credential types...
There was a problem hiding this comment.
Can you elaborate on how was it missed? So I will be able to catch it faster in the future
There was a problem hiding this comment.
These are old tests, written before I started working on this project.
I noticed that var.second_run wasn't used in any of the tests. If it's not used, "update" isn't tested.
For "update" to work properly I had to add "omitempty" to some of the structures (this is why vault failed to pass).
In other words, there were bugs in the provider that were not detected because tests were missing.
I added the tests and fixed the bugs. Now it should all work as expected.
github-actions
bot
added
ready to merge
Issue & Steps to Reproduce / Feature Request
resolves #743
Solution
Last PR for the OIDC effort. This one covers Vault OIDC.