Feat: support removal_strategy on destroy environment #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
feature
provider
api-client
integration-tests
github-actions
labels
TomerHeber
commented
Mar 21, 2024
| @@ -41,7 +41,7 @@ jobs: | |||
| uses: goreleaser/goreleaser-action@v5 | |||
| with: | |||
| version: latest | |||
| args: release --rm-dist | |||
| args: release --clean | |||
There was a problem hiding this comment.
unrelated.
--rm-dist is deprecated.
TomerHeber
commented
Mar 21, 2024
| @@ -335,6 +335,13 @@ func resourceEnvironment() *schema.Resource { | |||
| Optional: true, | |||
| Default: false, | |||
| }, | |||
| "removal_strategy": { | |||
| Type: schema.TypeString, | |||
| Description: "by default when removing an environment, it gets destroyed. Setting this value to 'mark_as_archived' will force the environment to be archived instead of tying to destroy it ('Mark as inactive' in the UI)", | |||
There was a problem hiding this comment.
I hope the description is clear enough.
tomer-landesman
approved these changes
Mar 27, 2024
github-actions
bot
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue & Steps to Reproduce / Feature Request
resolves #806
Solution