Feat: add support for variable set assignment resource #870
Conversation
|
there are usages of both |
| Schema: map[string]*schema.Schema{ | ||
| "scope": { | ||
| Type: schema.TypeString, | ||
| Description: "the resource(scope) type to assign to. Valid values: 'template', 'environment', 'workflow', 'organization', 'project'", |
There was a problem hiding this comment.
the allowed values are: organization, project, template, module, environment, deployment
https://docs.env0.com/reference/configuration-find-set-assignments-by-scope see what the assignmentScope is allowed to be.
There was a problem hiding this comment.
thank you. will fix.
|
|
||
| newSchemaSetIds := []string{} | ||
|
|
||
| // To avoid drifts keep the schema order as much as possible. |
There was a problem hiding this comment.
if that functionality prevents drift, can we add a test that drifts won't occur?
something like:
- set some assignments in the state
- mock that all return from api in addition to new ones
- see the order is kept as expected
There was a problem hiding this comment.
yes. This PR is still work in progress. I will definitely add such a test.
yeah for the printing of messages. Sure thing. |
@sagilaufer1992 - thanks! |
| resource "env0_variable_set_assignment" "assignment" { | ||
| scope = "project" | ||
| scope_id = env0_project.project.id | ||
| set_ids = var.second_run ? [env0_variable_set.org_scope.id] : [env0_variable_set.project_scope.id] |
There was a problem hiding this comment.
the test seems a bit missing... can we check the outcome of that? using output or some other method, to see that the assignment doesn't exist on the org after the second run, and exists where it should after on each run?
There was a problem hiding this comment.
This is tested in the acceptance tests.
The integration tests are limited in their functionality and are more of a sanity just to make sure things really work...
I don't think there's an easy way to test what you're asking with the current integration tests... /:
There was a problem hiding this comment.
Alright. As long as there is a test for it
github-actions
bot
added
ready to merge
Issue & Steps to Reproduce / Feature Request
Part of #829
Solution