Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eddyViscosity - PiOmega_hat #61

Open
rmojgani opened this issue Apr 11, 2024 · 1 comment
Open

eddyViscosity - PiOmega_hat #61

rmojgani opened this issue Apr 11, 2024 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed question Further information is requested sgs models issues related to sgs models

Comments

@rmojgani
Copy link
Member

https://github.com/envfluids/py2d/blob/e15e9ba5677ce9a838d1cecac7595f9a640caf60/py2d/Py2D_solver.py#L389C1-L390C74
Is eddyViscosity in

        Omega_hat_temp = RHS/(1+dt*alpha + 0.5*dt*(nu+eddyViscosity)*Ksq)

consistent with PiOmega_hat in

        RHS = Omega1_hat - dt*(convec_hat) + dt*0.5*(nu+eddyViscosity)*diffu_hat - dt*(Fk_hat+PiOmega_hat) + dt*beta*V1_hat
@rmojgani rmojgani added documentation Improvements or additions to documentation help wanted Extra attention is needed question Further information is requested labels Apr 11, 2024
@jakharkaran
Copy link
Collaborator

Correct. Eddy viscosity models are using Crank Nicholsoin time integration scheme while PiOmega is using Forward Euler (with an option for Adam Bashforth). We can figure out how to fix this later.

@jakharkaran jakharkaran added the sgs models issues related to sgs models label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed question Further information is requested sgs models issues related to sgs models
Projects
None yet
Development

No branches or pull requests

2 participants