Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] Enable Contribution of Experimental Processing Extensions #233

Open
missBerg opened this issue Jan 30, 2025 · 5 comments
Open
Labels
discussion To be discussed in community

Comments

@missBerg
Copy link
Contributor

missBerg commented Jan 30, 2025

Description:
This Issue is for discussing how we can enable experimental data plane processing steps and control plane APIs

Relevant Links:
See notes from community meeting: https://docs.google.com/document/d/10e1sfsF-3G3Du5nBHGmLjXw5GVMqqCvFDqp_O65B0_w/edit?tab=t.0#heading=h.h7jtr1uxwvpi

cc @envoyproxy/ai-gateway-maintainers @envoyproxy/ai-gateway-assignable

@missBerg missBerg added the discussion To be discussed in community label Jan 30, 2025
mathetake added a commit that referenced this issue Jan 30, 2025
**Commit Message**:

This does the two re-organization of packages:
* Renames `filterconfig` to `filterapi` 
* Put `extprocapi` into `filterapi/x` package 

The `filterapi/x` package will serve as an experimental
package that facilitates the development of such features.
Notably, custom routers etc while keeping the ability to
introduce breaking changes at any release. This will be 
for advanced users as well as core contributors to iterate
on some advanced features in the single repo.

**Related Issues/PRs (if applicable)**:

For #233

Signed-off-by: Takeshi Yoneda <[email protected]>
@mathetake
Copy link
Member

So I did a small refactoring of the Go packages before the v0.1.0rc release: #234. Based on that, the automatic model selection stuff proposed by @rootfs can live inside the experimental package https://github.com/envoyproxy/ai-gateway/blob/main/filterapi/x/x.go just like the custom router stuff (which requires the rebuild though).

I think the semantics caching (#30) will also fall into the same style of "calling out from the extproc"? cc @Krishanx92
Then let's start with the API design of "AI Gateway Semantics Processor" i guess ... which I believe will be a gRPC service

@rootfs
Copy link

rootfs commented Jan 30, 2025

Sounds good! I'll rebase to the latest code and create a PR.

@mathetake
Copy link
Member

mathetake commented Jan 30, 2025

yeah the initial PR should be only focused on the API of the external gRPC sever - no other stuff needed yet !

@rootfs
Copy link

rootfs commented Jan 30, 2025

@mathetake it would be counterproductive to review an API protocol without a supporting PoC :D

@mathetake
Copy link
Member

ok up to you - it would be helpful for reviews anyways!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion To be discussed in community
Projects
None yet
Development

No branches or pull requests

3 participants