bug fix to requested resource does not exist handling #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #373 +/- ##
============================================
- Coverage 86.16% 86.15% -0.02%
Complexity 361 361
============================================
Files 42 42
Lines 1178 1177 -1
Branches 97 97
============================================
- Hits 1015 1014 -1
Misses 116 116
Partials 47 47 ☔ View full report in Codecov by Sentry. |
|
@staticfinalzero looks like you haven't signed off your commit and that causes CI to be red. Any chance you can fix? |
we need to keep watch active for when resource is finally created so we can notify client. envoyproxy#219 Signed-off-by: staticfinalzero <[email protected]>
|
Sorry about that, I've amended the commit and signed off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix to requested resource does not exist handling. We need to keep watch active for when resource is finally created so we can notify client.
This is to match the xDS spec for how to handle the "resource does not exist" scenario.
Open issue: #219