Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out future of /retest app #1377

Open
phlax opened this issue Dec 28, 2023 · 4 comments
Open

Figure out future of /retest app #1377

phlax opened this issue Dec 28, 2023 · 4 comments

Comments

@phlax
Copy link
Member

phlax commented Dec 28, 2023

We made a load of changes to the retest app recently to work with Envoy's new CI framework

This may have broken some users as the logic is now more tied to Envoy's checks and essentially the github/checks action which has related logic

It was my intention to fold the action into that one

I reckon we can support a generic /retest one way/other so i guess its a case of figuring out how/where to maintain the code

@phlax
Copy link
Member Author

phlax commented Dec 28, 2023

cc @mmorel-35

cc @zirain

@zirain
Copy link

zirain commented Dec 29, 2023

EG(envoy gateway) use retest app, and EG use github action only.
I'm glad to see this happen, and will help to maintain it as possible as I can.

@phlax
Copy link
Member Author

phlax commented Jan 8, 2024

i spent some time looking at this at the end of last week

essentially Envoys needs are different - it looks for failed checks rather than runs and then uses the checks to restart the runs

im thinking the best way forward is to shift the envoy code to the github/checks app, and then ~revert this to the pre-change version (and remvoe the azp code)

ill update as i have some time

@zirain
Copy link

zirain commented Jan 8, 2024

Thanks for your updates, one it's ready, please ping me to give a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants