Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong number of arguments in proxy.rb and writer.rb #666

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix wrong number of arguments in proxy.rb and writer.rb #666

wants to merge 1 commit into from

Conversation

juicy-g
Copy link

@juicy-g juicy-g commented Jul 8, 2022

  • I have added or updated the specs/tests.
  • I have verified that the specs/tests pass on my computer.
  • I have not attempted to bump, or alter versions.
  • This is a documentation change.
  • [ x] This is a source change.

Description

@juicy-g juicy-g requested a review from envygeeks as a code owner July 8, 2022 02:27
@xaviershay
Copy link

I needed this change, thanks.

@quantum5 quantum5 mentioned this pull request Sep 7, 2023
Open
5 tasks
willkoehler added a commit to willkoehler/my_blog that referenced this pull request Jan 3, 2024
@willkoehler
Lock Ruby to v2.7.8
6393746 
Trying to get this blog running on Ruby 3.x led to a whole series of problems with old gems that are no longer being maintained.

See https://stackoverflow.com/a/72906202/935514
See envygeeks/jekyll-assets#666
See envygeeks/jekyll-assets#668
See Shopify/liquid#1625
@bravecrayon
Copy link

I was just about to create a pull request for my fix for this but then I found this and #668.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@envygeeks envygeeks Awaiting requested review from envygeeks envygeeks is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juicy-g @xaviershay @bravecrayon