Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cap PILLOW<10 to avoid moviepy compatibility issues #5

Merged
merged 3 commits into from
Aug 21, 2023

Conversation

lrq3000
Copy link
Collaborator

@lrq3000 lrq3000 commented Aug 15, 2023

A new version of PILLOW was uploaded, and MoviePy relies on PILLOW, but unfortnately moviepy is not actively maintained anymore since at least december 2022.

This PR caps PILLOW below the version that introduces a breaking change. In the future, if MoviePy is again maintained by someone else, we can just stop the capping or install from git (the git is still updated, but it can stop at any moment).

I’m going to publish to PyPi after this PR gets merged.

…DME.md with known issues + bump v0.2.10

Signed-off-by: Stephen L. <[email protected]>
Signed-off-by: Stephen L. <[email protected]>
@lrq3000 lrq3000 added the bug Something isn't working label Aug 15, 2023
@lrq3000 lrq3000 requested a review from eobrain August 15, 2023 14:23
@lrq3000
Copy link
Collaborator Author

lrq3000 commented Aug 15, 2023

Also note that PILLOW >= 10 drops support for Python 3.7, so we will need to drop support as well when we will update.

… standard now to manage dependencies)

Signed-off-by: Stephen L. <[email protected]>
Copy link
Owner

@eobrain eobrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

@eobrain eobrain merged commit 80ca6cc into eobrain:main Aug 21, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants