From e4bb8c41d5664e13f258461edadd17733235d786 Mon Sep 17 00:00:00 2001 From: Stephen L Date: Tue, 15 Aug 2023 15:53:15 +0200 Subject: [PATCH 1/3] fix: cap PILLOW<10 to avoid moviepy compatibility issues + update README.md with known issues + bump v0.2.10 Signed-off-by: Stephen L. --- README.md | 18 ++++++++++++++++++ pyproject.toml | 3 ++- 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 85ac04a..784195d 100644 --- a/README.md +++ b/README.md @@ -87,6 +87,24 @@ It can also be installed in development/editable mode after cloning this git rep pip install --upgrade -e . ``` +## Known issues + +There are a few known issues, due to the fact that moviepy, the library that we use to process videos, is [currently not actively maintained as of August 2023](https://github.com/Zulko/moviepy/issues/1874). Here is a list of downstream issues: +* PILLOW 10.0.0 introduced a breaking change with moviepy, and although [a fix](https://github.com/Zulko/moviepy/pull/2003) was merged upstream into moviepy, there is no pypi release. Two solutions: cap PILLOW below 10, or install moviepy from github. Since the future of moviepy is uncertain, we chose to cap PILLOW, to ensure this tool continues to work in venvs. +* On Windows, after saving the output, the following exception may arise: +``` +Exception ignored in: +Traceback (most recent call last): + File "C:\Users\33632\miniconda3\Lib\site-packages\moviepy\video\io\ffmpeg_reader.py", line 199, in __del__ + self.close() + File "C:\Users\33632\miniconda3\Lib\site-packages\moviepy\video\io\ffmpeg_reader.py", line 190, in close + self.proc.terminate() + File "C:\Users\33632\miniconda3\Lib\subprocess.py", line 1671, in terminate + _winapi.TerminateProcess(self._handle, 1) +OSError: [WinError 6] Descripteur non valide +``` +Again this was [fixed](https://github.com/Zulko/moviepy/pull/1296) on github but not in the latest pypi release of MoviePy. This remain unfixed, it does not prevent usage of the tool, it is just inelegant. + ## License Created by Eamonn O'Brien-Strain. diff --git a/pyproject.toml b/pyproject.toml index 15029f5..43dc7e2 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -7,7 +7,7 @@ build-backend = "setuptools.build_meta" [project] # beware if using setuptools: setup.py still gets executed, and even if pyproject.toml fields take precedence, if there is any code error in setup.py, building will fail! name = "videogestalt" -version = "0.2.9" # see PEP 440 https://peps.python.org/pep-0440/#pre-releases and https://packaging.python.org/en/latest/guides/single-sourcing-package-version/ +version = "0.2.10" # see PEP 440 https://peps.python.org/pep-0440/#pre-releases and https://packaging.python.org/en/latest/guides/single-sourcing-package-version/ description = "One-Glance Overview of Any Video" authors = [ {name = "Eamonn O'Brien-Strain", email = "eobrain@proton.me"}, @@ -46,6 +46,7 @@ classifiers = [ 'Topic :: Utilities', ] dependencies = [ + "PILLOW<10", # PILLOW 10.0.0 introduced a breaking change with moviepy, and unfortunately MoviePy is unmaintained as of august 2023 (since december 2022) so a new release is unlikely, see https://github.com/Zulko/moviepy/pull/2003 -- an easy solution is to cap PILLOW "moviepy", ] From 8a87277d00a5f0b6c657fc67a905d26f42d31680 Mon Sep 17 00:00:00 2001 From: Stephen L Date: Tue, 15 Aug 2023 16:21:24 +0200 Subject: [PATCH 2/3] docs: clarify date Signed-off-by: Stephen L. --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 784195d..3416c7d 100644 --- a/README.md +++ b/README.md @@ -89,7 +89,7 @@ pip install --upgrade -e . ## Known issues -There are a few known issues, due to the fact that moviepy, the library that we use to process videos, is [currently not actively maintained as of August 2023](https://github.com/Zulko/moviepy/issues/1874). Here is a list of downstream issues: +There are a few known issues, due to the fact that moviepy, the library that we use to process videos, is [currently not actively maintained as of August 2023 since at least December 2022](https://github.com/Zulko/moviepy/issues/1874). Here is a list of downstream issues: * PILLOW 10.0.0 introduced a breaking change with moviepy, and although [a fix](https://github.com/Zulko/moviepy/pull/2003) was merged upstream into moviepy, there is no pypi release. Two solutions: cap PILLOW below 10, or install moviepy from github. Since the future of moviepy is uncertain, we chose to cap PILLOW, to ensure this tool continues to work in venvs. * On Windows, after saving the output, the following exception may arise: ``` From bcfca2b34e9f897aab9c075ea3475583d6366c19 Mon Sep 17 00:00:00 2001 From: Stephen L Date: Tue, 15 Aug 2023 16:26:31 +0200 Subject: [PATCH 3/3] build: remove deprecated Makefile (since we use PEP517 pyproject.toml standard now to manage dependencies) Signed-off-by: Stephen L. --- Makefile | 20 -------------------- 1 file changed, 20 deletions(-) delete mode 100644 Makefile diff --git a/Makefile b/Makefile deleted file mode 100644 index 49eff58..0000000 --- a/Makefile +++ /dev/null @@ -1,20 +0,0 @@ -MOVIEPY_INSTALL=$(HOME)/.local/lib/python3.9/site-packages/moviepy/__init__.py - - -gestalt-test.mp4: test.mp4 preconditions - ./gestalt.py -i test.mp4 -g -v - -preconditions: /usr/bin/python $(MOVIEPY_INSTALL) - -$(MOVIEPY_INSTALL): /usr/bin/pip - pip install moviepy - -/usr/bin/pip: - sudo apt-get install pip - - -/usr/bin/python3: - sudo apt-get install python3 - -im: - sudo apt-get install imagemagick