Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine Schedule Timing and Schedule Unit in to a single attribute #97

Open
4 tasks
eoyilmaz opened this issue Nov 4, 2024 · 0 comments
Open
4 tasks
Milestone

Comments

@eoyilmaz
Copy link
Owner

eoyilmaz commented Nov 4, 2024

User Story

As the developer of Stalker I want to combine ScheduleMixin.schedule_timing and ScheduleMixin.schedule_unit into a single attribute which might be called a ScheduleInfo that combines the schedule related data and logic into one class, so that it is easiear to maintain schedule realated code.

Acceptance Criteria

  • Create a new class called ScheduleInfo.
  • Add attributes like timing, unit, model, constraint.
  • Move ScheduleMixin methods and properties like schedule_seconds (rename to seconds), to_unit(), to_seconds(), least_meaningful_time_unit() to this class.
  • Allow it to understand string values like "10h", "1h5m" etc.
@eoyilmaz eoyilmaz added this to the 1.x milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant