From 7890f61e81ab3574eaab485b6d0a211e8a2f0b98 Mon Sep 17 00:00:00 2001 From: Aliaksandr Stsiapanay Date: Tue, 11 Feb 2025 11:34:55 +0300 Subject: [PATCH] fix: add double quota as invalid char in file names for GCP --- .../epam/aidial/core/server/util/ResourceDescriptorFactory.java | 2 +- .../aidial/core/server/util/ResourceDescriptorFactoryTest.java | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/server/src/main/java/com/epam/aidial/core/server/util/ResourceDescriptorFactory.java b/server/src/main/java/com/epam/aidial/core/server/util/ResourceDescriptorFactory.java index 06374d88d..b78b98882 100644 --- a/server/src/main/java/com/epam/aidial/core/server/util/ResourceDescriptorFactory.java +++ b/server/src/main/java/com/epam/aidial/core/server/util/ResourceDescriptorFactory.java @@ -16,7 +16,7 @@ public class ResourceDescriptorFactory { - private static final Set INVALID_FILE_NAME_CHARS = Set.of('/', '{', '}'); + private static final Set INVALID_FILE_NAME_CHARS = Set.of('/', '{', '}', '"'); private static final int MAX_PATH_SIZE = 900; /** diff --git a/server/src/test/java/com/epam/aidial/core/server/util/ResourceDescriptorFactoryTest.java b/server/src/test/java/com/epam/aidial/core/server/util/ResourceDescriptorFactoryTest.java index 0c13773e3..d3d33d505 100644 --- a/server/src/test/java/com/epam/aidial/core/server/util/ResourceDescriptorFactoryTest.java +++ b/server/src/test/java/com/epam/aidial/core/server/util/ResourceDescriptorFactoryTest.java @@ -159,6 +159,8 @@ public void testResourceWithInvalidFilename() { () -> ResourceDescriptorFactory.fromEncoded(ResourceTypes.FILE, "bucket", "location/", "fol%0Fder1")); assertThrows(IllegalArgumentException.class, () -> ResourceDescriptorFactory.fromEncoded(ResourceTypes.FILE, "bucket", "location/", "//file.txt")); + assertThrows(IllegalArgumentException.class, + () -> ResourceDescriptorFactory.fromEncoded(ResourceTypes.FILE, "bucket", "location/", "folder1%22")); } @Test