Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout for antisense chains in sequence mode #5925

Closed
ljubica-milovic opened this issue Nov 6, 2024 · 1 comment · Fixed by #6032
Closed

Layout for antisense chains in sequence mode #5925

ljubica-milovic opened this issue Nov 6, 2024 · 1 comment · Fixed by #6032
Assignees
Labels
Antisense Bucket: Antisense related issues Hydrogen bonds Bucket: Bugs related to Hydrogen bonds Sequence mode Bucket: Sequence mode related issues Test Cases Written Test cases has been written for that issue

Comments

@ljubica-milovic
Copy link
Collaborator

ljubica-milovic commented Nov 6, 2024

Background

This is the first version of representation of sense and antisense chains in sequence mode, and will be amended shortly.

Requirements

  1. Sense and antisense chains should be treated as completely separate chains in sequence mode, without any hydrogen bonds connecting them.

In snake mode:
image
In sequence mode:
image

2. Right-clicking on the sequence (without selecting monomers) should give the option to: "Create Antisense Strand".

3. When multiple monomers are selected, the user should have the option to "Create Antisense Strand" in the r-click menu.

4. For requirements 2 and 3 the same conditions for the chain/selected monomers have to be met as for selected monomers in this ticket: #5678

5. The logic for creating antisense chains is identical to the logic for snake and flex modes.

6. The new antisense chain should be placed in the line bellow the sense chain.
Points 2-6 excluded from the scope of current task

In sequence mode:
image>
Snake mode:
image

@ljubica-milovic ljubica-milovic added feature request Sequence mode Bucket: Sequence mode related issues Hydrogen bonds Bucket: Bugs related to Hydrogen bonds labels Nov 6, 2024
@Zhirnoff Zhirnoff added the Test Cases Written Test cases has been written for that issue label Nov 12, 2024
@rrodionov91 rrodionov91 self-assigned this Nov 29, 2024
@rrodionov91 rrodionov91 linked a pull request Nov 29, 2024 that will close this issue
9 tasks
@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Dec 5, 2024

Tested.
2024-12-04_14h05_59

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.28.0-rc.1]
Indigo version
[Version 1.27.0-rc.1]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Antisense Bucket: Antisense related issues Hydrogen bonds Bucket: Bugs related to Hydrogen bonds Sequence mode Bucket: Sequence mode related issues Test Cases Written Test cases has been written for that issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants