Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note regarding what to push to public GitHub and what to keep within DLS GitLab #178

Closed
JamesOHeaDLS opened this issue Sep 25, 2024 · 3 comments

Comments

@JamesOHeaDLS
Copy link

Hello,

At the moment the wording in the 'Create a Generic IOC' section sounds like all modules should be pushed to GitHub. However, talking to @coretl today, he mentioned that there will be quite a few DLS specific modules which won't benefit from moving to GitHub and can stay on GitLab.

It may be worth adding a note at the beginning of this section explaining how to decide where the repo should reside

Thanks,

James

@gilesknap gilesknap mentioned this issue Dec 4, 2024
10 tasks
@gilesknap
Copy link
Member

@JamesOHeaDLS
Copy link
Author

Thanks @gilesknap - yes that message is good although I think it would be worth saying what a PVC is/provide a link to more info about PVCs

"....supply the proprietary library at runtime via a PVC"

@gilesknap
Copy link
Member

Agreed. But I need to write a whole section on that. In the meantime I just wanted a note to say that there is a workaround to proprietary libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants