Enabling Single Fetch

[hakimLyon]

This PR enables the v3_singleFetch feature.

[kentcdodds]

Thank you! Could you debug the playwright failures please?

[kentcdodds]

Thanks for this! I have a few notes.

[itzmegood]

Will it be possible to have a codemod for this upgrade. Manually upgrading all this for custom/ extended project seems a bit difficult.

[kentcdodds]

Maybe @jacobparis's tool could help.

[itzmegood]

Maybe @jacobparis's tool could help.

I found this https://codemod.com/registry/remix-single-fetch-recipe by jacobparis.
Also curious about your thoughts on switching to biome? (less code/ faster)

[jacobparis]

Maybe @jacobparis's tool could help.

I found this https://codemod.com/registry/remix-single-fetch-recipe by jacobparis. Also curious about your thoughts on switching to biome? (less code/ faster)

I should take that down, it's for an old outdated single fetch API

Remix team is working on some codemods for this now though

[itzmegood]

Any update regarding this @kentcdodds , gentle reminder that RR7 was released, so if you wanna revamp, add / switch out some tech like biome or hono or bun feel free to ask =]

[bkilrain]

I'm in the middle of the same single fetch effort on an app based off this template. I hit some funkiness with how the toasts work for error responses so came over here to see how y'all are handling it.

The new behavior is that loaders don't rerun by default when an action returns a 4xx/5xx response. This means the root loader doesn't process the toast headers until the next GET/successful POST.

@hakimLyon have you noticed if the toasts still work in this case?

[hakimLyon]

@hakimLyon have you noticed if the toasts still work in this case?

Hi @bkilrain , I haven’t noticed this behavior on my side. But in Remix Docs about Submission Revalidation Behavior
It suggests using options like shouldRevalidate to customize this behavior and force loaders to rerun if needed.

[bkilrain]

@hakimLyon have you noticed if the toasts still work in this case?

Hi @bkilrain , I haven’t noticed this behavior on my side. But in Remix Docs about Submission Revalidation Behavior It suggests using options like shouldRevalidate to customize this behavior and force loaders to rerun if needed.

Yep that's what I ended up doing on my side... just raising the possibility that this PR might need it as well.

export const shouldRevalidate: ShouldRevalidateFunction = ({
  defaultShouldRevalidate,
  actionStatus,
}) => {
  const status = String(actionStatus)
  if (status.startsWith('4') || status.startsWith('5')) {
    // 4xx & 5xx error response should be revalidated in case they contain toast headers
    return true
  }
  return defaultShouldRevalidate
}

[kentcdodds]

Thank you so much for all your contributions to this and the #897 PR! Merged that other one so we're all set!