-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
playground app start in new port each time #61
Comments
I can't reproduce this issue. When we set the playground we:
And only after that is all done do we copy things over and start the server up again. So I have no idea how this could happen 🤔 |
maybe it is related to this "unstable_dev" doesn't kill app server on exit (Windows) |
That does appear to be related. |
I wanted to clarify that i've tested it on
this helped export async function closeProcess(key: string) {
const proc = devProcesses.get(key)
if (proc) {
+ if (process.platform === 'win32') {
+ const { execa } = await import('execa')
+ await execa('taskkill', ['/pid', String(proc.process.pid), '/f', '/t'])
+ } else {
proc.process.kill()
+ }
await stopPort(proc.port) // 🤷♂️
devProcesses.delete(key)
}
} |
Interesting. Well, I guess we should do that then. Thanks for the research! |
It will be interesting to see how kcdshop and the workshop apps will work with remix v1.16 with |
fixed by #69 |
Yay! |
With the latest kcdshop 1.36.0
When calling
SET TO PLAYGROUND
while playground app is running the app starts in a new port each time.see the following log from my terminal.
playground start in new port each time
output from running
netstat -aon
in Windows 11 terminal, there are many:TCP some_ip_address:4000 some_ip_address:64999 TIME_WAIT 0
(i've removed the real ips)
Active Connections on Windows
The text was updated successfully, but these errors were encountered: