Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick start in README vs. workflow vignette #482

Closed
sbfnk opened this issue Oct 19, 2023 · 21 comments · Fixed by #521
Closed

Quick start in README vs. workflow vignette #482

sbfnk opened this issue Oct 19, 2023 · 21 comments · Fixed by #521
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@sbfnk
Copy link
Contributor

sbfnk commented Oct 19, 2023

There is a fair amount of duplication between the quick start section in the README and the workflow vignette.

I wonder if there's a case for shortening the README to take out the code examples in the Quick start section and moving any of the bits that aren't in the vignette yet there (e.g. the paragraph on estimating delays), and instead pointing to the vignette.

@seabbs
Copy link
Contributor

seabbs commented Oct 19, 2023

Do you know what current thinking is on having a readme quick start vs linking out to a vignette? I'm definitely open to the idea but we will need to make a very big effort to signpost users so they don't get lost.

@sbfnk
Copy link
Contributor Author

sbfnk commented Oct 19, 2023

I guess this? https://r-pkgs.org/other-markdown.html#sec-readme

  1. A paragraph that describes the high-level purpose of the package.
  1. An example that shows how to use the package to solve a simple problem.
  1. Installation instructions, giving code that can be copied and pasted into R.
  1. An overview that describes the main components of the package. For more complex packages, this will point to vignettes for more details. This is also a good place to describe how your package fits into the ecosystem of its target domain.

Which perhaps is what there is at the moment. Or perhaps the package doesn't solve any simple problems, which makes the whole thing more involved straight away (and links to point 4 above).

I'm really not particularly inclined one way or the other, just that looking at the using examples vs. specifying delays question I noticed how much we repeat the same examples across the package (which might be a good thing, just gets cumbersome when wanting to make changes).

@seabbs
Copy link
Contributor

seabbs commented Oct 20, 2023

I think in general some repition of the core concepts is not that bad given how much of a struggle it is to get users to read the docs but if its a pain to keep everything in sync (which it is) I think it makes sense having one really good getting started vignette and very clearly directing people from the README to it. I've been thinking about doing this for epinowcast as it doesn't have just one getting started option (do you want Rt, a nowcast etc) and so the quick start is just a bit confusing (which is also true of EpiNow2.

@sbfnk
Copy link
Contributor Author

sbfnk commented Oct 23, 2023

One example I personally like is the rstanarm README.

Perhaps we could have something like:

  • 1-2 paragraph high-level summary
  • Arrows for:
    1. more detail
    2. models contained (estimate_infections, estimate_truncation, estimate_secondary, estimate_delay)
  • Resources (links to vignettes including getting started)
  • Installation
  • Contributing

@seabbs
Copy link
Contributor

seabbs commented Oct 23, 2023

Yes, that is a nice example. I like the proposed structure. Something I have wanted for a long time is as an automated section that lists contributors in the README but that can be addressed as its own issue/discussion.

@jamesmbaazam
Copy link
Contributor

One example I personally like is the rstanarm README.

Perhaps we could have something like:

  • 1-2 paragraph high-level summary

  • Arrows for:

    1. more detail
    2. models contained (estimate_infections, estimate_truncation, estimate_secondary, estimate_delay)
  • Resources (links to vignettes including getting started)

  • Installation

  • Contributing

You have my upvote. I've always thought the quick start section of the "README" could be moved to the "Getting Started" vignette because currently, the readme is quite long and intimidating.

@seabbs
Copy link
Contributor

seabbs commented Oct 23, 2023

"Getting Started" vignette because currently, the readme is quite long and intimidating.

In some sense this just moves the problem as then the getting started vignette will be intimidating! Would be good to work on this though potentially it is just a little bit of an intimidating tool.

@jamesmbaazam
Copy link
Contributor

In some sense this just moves the problem as then the getting started vignette will be intimidating!

I don't think so. I think it's more about how much information a NEW user is bombarded with when they land on the page. It's good to ease the user into the information you want to give them.

On the landing page, they'll see what the package does and with what functions, then they'll wonder, "how can I use function x then?" -> Getting started vignette

"Okay, that was easy but that's not how it works in real life. I usually have to do a lot of things before getting to this step" -> (workflow vignette)

"How do I connect these ideas?" -> case studies

@seabbs
Copy link
Contributor

seabbs commented Oct 23, 2023

Fair enough. Have you seen any literature discussing this? Seems to hang on whether people clicking through things reduces the burden on them - which I imagine it probably does to some degree unless they can't find the things to click (which happens to a lot of users).

@jamesmbaazam
Copy link
Contributor

jamesmbaazam commented Oct 24, 2023

This article has good references on the topic.

For example,

@seabbs
Copy link
Contributor

seabbs commented Oct 24, 2023

Amazing! I'll give those a read.

@jamesmbaazam
Copy link
Contributor

Enjoy. Very interesting literature.

@jamesmbaazam
Copy link
Contributor

jamesmbaazam commented Oct 24, 2023

Makes me wonder if we might want to set up a small user survey via .onLoad() to find out more about the user community.

@seabbs
Copy link
Contributor

seabbs commented Oct 25, 2023

Makes me wonder if we might want to set up a small user survey via

That is an interesting idea. data.table recently put out a survey though I am not sure about putting it in .onLoad() - feels a bit invasive?

@jamesmbaazam
Copy link
Contributor

Oh, I just looked it up. I suggested .onLoad() because it's the closest to a user who doesn't interact with GitHub. I think the README would be a good place too. Not sure what the general practice is but could dig around if we think it's a good idea to carry it forward. Linking to the thread for the data.table survey here for future reference Rdatatable/data.table#5686.

@LizaHadley
Copy link

I like to be walked through new things :)

@jamesmbaazam
Copy link
Contributor

I really like the change to the epinowcast README (dropdown arrows so cool 🤩 ) and "Getting Started" vignette here epinowcast/epinowcast#375.

Should I go ahead with this PR?

@jamesmbaazam jamesmbaazam self-assigned this Nov 22, 2023
@jamesmbaazam jamesmbaazam added the documentation Improvements or additions to documentation label Nov 22, 2023
@jamesmbaazam jamesmbaazam added this to the CRAN v2.0 release milestone Nov 22, 2023
@jamesmbaazam
Copy link
Contributor

jamesmbaazam commented Nov 24, 2023

@seabbs and @sbfnk

I'm working on this and have a few questions:

  1. Should this PR just focus on moving things around then having follow-up PRs to remove the duplications between the the Getting Started vignette and estimate_infections() workflow vignette?
  2. In the contributing section in the README, I would suggest we remove "Please note that due to operational constraints priority will be given to users informing government policy or offering methodological insights" and decide on this on a case-by-case basis when we get contributions as it might discourage new contributors.
  3. Is this a good time to remove the reporting templates section as suggested by @seabbs here Reporting templates and the report package #495 (comment)?

@sbfnk
Copy link
Contributor Author

sbfnk commented Nov 28, 2023

I see you've answered (1) with yes which makes sense to me.

(2) I agree

(3) I think so, yes - though can be done in a follow-up PR to keep things clear/contained.

@jamesmbaazam
Copy link
Contributor

though can be done in a follow-up PR to keep things clear/contained.

True.

@seabbs
Copy link
Contributor

seabbs commented Nov 28, 2023

"Please note that due to operational constraints priority will be given to users informing government policy or offering methodological insights"

This is yet more legacy from when we were getting multiple support emails a day so can definitely go.

@github-project-automation github-project-automation bot moved this from Todo to Done in EpiNow2 v2.0.0 Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants