Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hard coded parameters/distributions #59

Open
sbfnk opened this issue Nov 28, 2023 · 0 comments · May be fixed by #84
Open

Hard coded parameters/distributions #59

sbfnk opened this issue Nov 28, 2023 · 0 comments · May be fixed by #84

Comments

@sbfnk
Copy link
Contributor

sbfnk commented Nov 28, 2023

Some parameters/distributions are hardcoded, e.g. the incubation period in

ringbp/R/outbreak_model.R

Line 56 in f8f1809

incfn <- dist_setup(dist_shape = 2.322737,

and the Weibull distribution in

ringbp/R/aux_functions.R

Line 11 in f8f1809

out <- purrr::partial(rweibull,

It would be good to make these arguments for greater generalisability
This was referenced Nov 28, 2023
Open
Closed
joshwlambert added a commit to joshwlambert/ringbp that referenced this issue Mar 10, 2025
@joshwlambert
add incfn argument to outbreak_model and scenario_sim and remove hard…
60c7eed 
…coding, fixes epiforecasts#59
@joshwlambert joshwlambert linked a pull request Mar 10, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Generalise distributions input into functions joshwlambert/ringbp
1 participant
@sbfnk