Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the plotting function for get_forecast_counts() a regular function instead of an S3 method #521

Closed
nikosbosse opened this issue Dec 5, 2023 · 1 comment
Closed

Make the plotting function for get_forecast_counts() a regular function instead of an S3 method #521

nikosbosse opened this issue Dec 5, 2023 · 1 comment
Labels
implementation-ready This is ready for implementation
Milestone
scoringutils-2.0

Comments

@nikosbosse
Copy link
Contributor

Currently, get_forecast_counts() produces an object of class prediction_counts and has an associated method for plot().

@sbfnk, @seabbs and I discussed that having extra classes just for plotting is maybe a bit too much. We should therefore revert this change and create a simple plotting function (basically following the previous plot_available_forecasts() we had. I suggest plot_forecast_counts() as a name.
@nikosbosse nikosbosse added the implementation-ready This is ready for implementation label Dec 5, 2023
@nikosbosse nikosbosse added this to the scoringutils 2.0.0 milestone Dec 5, 2023
@nikosbosse nikosbosse mentioned this issue Dec 5, 2023
Merged
9 tasks
@nikosbosse
Copy link
Contributor Author

Fixed via #511

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
implementation-ready This is ready for implementation
Projects
scoringutils 2.0
Status: Done
Milestone
scoringutils-2.0
Development

No branches or pull requests
1 participant
@nikosbosse