Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect peer dependency "class-validator@^0.9.1" #26

Open
lihaiswu opened this issue Jan 6, 2020 · 3 comments
Open

incorrect peer dependency "class-validator@^0.9.1" #26

lihaiswu opened this issue Jan 6, 2020 · 3 comments

Comments

@lihaiswu
Copy link

lihaiswu commented Jan 6, 2020

I use latest class-validator 0.11.0, and it log warning during yarn install for class-validator-jsonschema. I think it should upgrade to class-validator version 0.11.0 in class-validator-jsonschema.

yarn install v1.19.1
[1/4] 🔍 Resolving packages...
[2/4] 🚚 Fetching packages...
[3/4] 🔗 Linking dependencies...
warning " > [email protected]" has incorrect peer dependency "class-validator@^0.9.1".

@epiphone
Copy link
Owner

epiphone commented Jan 9, 2020

What do you propose as the new peer dependency version? Latest class-validator version is 0.11.0 but routing-controllers seems to still have a peer dependency to class-validator 0.10.1

@lihaiswu
Copy link
Author

lihaiswu commented Jan 9, 2020

@epiphone is it possible use latest class-validator 0.11.0 as the dependency version ?

@epiphone
Copy link
Owner

epiphone commented Jan 9, 2020

It is but then we'd end up with another warning of the same sort: " > [email protected]" has incorrect peer dependency "[email protected]".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants