Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widen "Uses a testing framework" to "Uses testing" #37

Open
TimTaylor opened this issue Jul 25, 2024 · 2 comments
Open

Widen "Uses a testing framework" to "Uses testing" #37

TimTaylor opened this issue Jul 25, 2024 · 2 comments

Comments

@TimTaylor
Copy link

Not sure how feasible this is without shallow cloning from https://github.com/cran but the idea is that you only check for a non-empty tests/ directory. I'm unsure if the GitHub api allows you to inspect the directory structures and avoid a shallow clone 🤷‍♂️

@Bisaloo
Copy link
Collaborator

Bisaloo commented Jul 25, 2024

I'm unsure if the GitHub api allows you to inspect the directory structures and avoid a shallow clone

Yes, this is technically possible


We had a related discussion yesterday. In particular with the example of data.table which doesn't use a testing framework.

I think it then potentially opens the question of "is it still best practice?" 🤔. I chatted with data.table contributors recently who shared how the unusual infrastructure made it more difficult for them to contribute.

My view is probably that:

no tests < tests with no testing framework < testing framework

On a slightly more general note, "best practices" is bound to be somewhat subjective. I tried to resolve this by linking to what we use as reference but I believe some room will always be left for interpretation.

@TimTaylor
Copy link
Author

On a slightly more general note, "best practices" is bound to be somewhat subjective. I tried to resolve this by linking to what we use as reference but I believe some room will always be left for interpretation.

Yeah I appreciate you've tried to avoid judgement in the analysis and I agree from a contribution perspective a framework tends to make it much easier.

That said the output table could possibly be split to have both "Uses testing" and "Uses testing framework" percentages?

... Maybe 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants