Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new change in r-devel affects how unique() behaves. Previously, calling unique() on a difftime object returned a numeric vector, but now it retains its difftime class.
Hence the following check in
cfr_static
,cfr_rolling
andcfr_time_varying
now fails:because diff(data$date) returns a difftime object, and unique(diff(data$date)) no longer simplifies to numeric.
It has therefore been replaced with:
Once this PR is complete, we'll release version 0.13 onto CRAN with the above fix.