Fix lintr by bumping minimum R version to 4.1.0 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request increases the minimum version of R required to use the {climateR0} package to 4.1.0, from 2.10.
I assume the dependency on R version 2.10 was automatically added to the package when you were adding other things, such as data with
usethis::use_data(). I believe the.lintrfile didn't like the 2.10 version, maybe because it expects versions to have three components (i.e. major.minor.patch) whereas 2.10 has just two.I've chosen 4.1.0 as the base R pipe (
|>) is used in the package which was added to R in 4.1.0, so ensuring user have 4.1.0 installed should ensure that the code works as expected.