Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider how to handle groups #46

Open
Bisaloo opened this issue Oct 8, 2024 · 0 comments
Open

Reconsider how to handle groups #46

Bisaloo opened this issue Oct 8, 2024 · 0 comments

Comments

@Bisaloo
Copy link
Member

Bisaloo commented Oct 8, 2024

This was triggered by @avallecam's messages on slack.

Currently, we state:

https://github.com/epiverse-trace/datatagr/blob/279c0c8d78640d54f547b2fb4778f4f553a06cab/vignettes/compat-dplyr.Rmd#L165

Is this really what we want? Or do we want to preserve labels in this situation? Or do we want to warn when unclassing the objects (rather than "silently" converting them)?

Closing this issue with "the current situation is fine" is an acceptable outcome. I just want to ensure we don't let unjustified historical decisions prevent us from improving the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant