-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full package review for v0.4.0 release #164
Conversation
Co-authored-by: Chris Hartgerink <[email protected]>
Co-authored-by: Chris Hartgerink <[email protected]>
… of RNGs from .add_ct update
This pull request:
Reach out on slack ( (Note that results may be inaccurate if you branched from an outdated version of the target branch.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @joshwlambert for being so active in inviting reviews in a timely fashion 😊
- I am pleased to see that you took my feedback from a previous moment on other packages, and made it possible to easily run these functions without having to specify further defaults. Being able to get started by running
sim_linelist()
is fairly rewarding 😄 - Your dilligent use of the
NEWS.md
and referring to the relevant issues is also 👍 - I have very little to mention on the testing here, even though I have been a broken record elsewhere. These tests are thorough and well done.
My only remaining question is: Do you want to release this on CRAN or is there still work to do to achieve the scope you are looking to achieve? It seems pretty solid to me, but I might be missing something you do see.
I am very glad to approve this. Moments like these are worth celebrating, so thank you @joshwlambert for delivering another good release! 🙌 🎊
Thanks for the review @chartgerink!
{simulist} is now ready to be submitted to CRAN. Once {epiparameter} is accepted onto CRAN, I will start the submission of {simulist} which will close #100. |
This PR is to provide a platform to review the entirety of the package.
Once this review concludes I will release v0.4.0 on GitHub and submit to CRAN. This release will occur after {epiparameter} is accepted by CRAN.
Please see the
NEWS.md
file for an overview of changes between v0.3.0 and v0.4.0. If you would prefer to review with a partial package review only showing the changes between v0.3.0 and v0.4.0 please let me know and I can open one.This PR is unconventional as it is not intended for merging or for additional commits (unless minor) and instead comments will be converted to issues and these will be addressed in their own PRs.