Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create loglog plot using prediction from Cox model #98

Merged
merged 7 commits into from
Nov 14, 2024

Conversation

davidsantiagoquevedo
Copy link
Member

@davidsantiagoquevedo davidsantiagoquevedo commented Nov 2, 2024

This PR resolves issue #84 by creating a log-log plot using predictions from the Cox model.

Main changes

  1. Added the cox_model_prediction function to calculate predictions.
  2. Modified coh_eff_hr to return predictions.
  3. Updated plot_loglog to generate the plot based on cox_model_prediction.
  4. Updated tests to reflect these changes.

This PR includes changes from #93 and #95. The changes specific to this PR start with commit 123d5c4.

Concerning the following comments,

Is it normal in this domain to return the results for multiple models at once? I am not used to this as it can create selective reporting. I would expect the function call to specify the model.
(#76 (comment))

I'm not sure if there's a specific reason why the package runs both models simultaneously (It might be useful, but my lack of expertise in the topic can blur this). Wouldn't it be more appropriate to include a parameter for each model, or allow users to run them separately? Will all users need to run both tests?
#76 (comment)

We decided to keep returning both models to give the whole context to the estimation, since the Kaplan-Meier is not used to estimate VE but to construct the Survival Curves.

@davidsantiagoquevedo davidsantiagoquevedo merged commit 62af725 into main Nov 14, 2024
1 of 7 checks passed
@davidsantiagoquevedo davidsantiagoquevedo deleted the 84-loglog-plot branch November 14, 2024 14:53
@davidsantiagoquevedo davidsantiagoquevedo restored the 84-loglog-plot branch November 14, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create loglog plot from Cox model estimation
2 participants