Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2P sync: clean up logging #2155

Open
CHr15F0x opened this issue Aug 6, 2024 · 2 comments
Open

P2P sync: clean up logging #2155

CHr15F0x opened this issue Aug 6, 2024 · 2 comments
Milestone

Comments

@CHr15F0x
Copy link
Member

CHr15F0x commented Aug 6, 2024

Add meaningful spans. This should shorten, unify and improve the value of sync logs be it on p2p client level or at the sync logic level.

@CHr15F0x CHr15F0x self-assigned this Aug 6, 2024
@CHr15F0x CHr15F0x removed their assignment Sep 2, 2024
@kkovaacs kkovaacs added this to the P2P sync milestone Oct 16, 2024
@CHr15F0x CHr15F0x self-assigned this Oct 30, 2024
@CHr15F0x
Copy link
Member Author

Some sync stages do not communicate important info like: current block number.

@CHr15F0x CHr15F0x changed the title P2P sync: cleanup logging P2P sync: clean up logging Oct 30, 2024
@CHr15F0x
Copy link
Member Author

CHr15F0x commented Nov 9, 2024

Example (thought this should not be a fatal error too):

  2024-11-09T09:23:39 ERROR pathfinder_lib::sync: Stopping track sync, error: No transactions
    at crates/pathfinder/src/sync.rs:186

  2024-11-09T09:23:39 DEBUG p2p::client::peer_agnostic::header_stream: Failed to yield to stream, terminating, peer: 12D3KooWC4fgZuc3dGF62JpUZAhsQFaYRJAZ4EVLQ7UXESMEV2rW
    at crates/p2p/src/client/peer_agnostic.rs:697

  2024-11-09T09:23:39  WARN p2p::main_loop: Outbound header sync request failed, request_id: OutboundRequestId(1), error: Io(Custom { kind: Other, error: SendError { kind: Disconnected } })
    at crates/p2p/src/main_loop.rs:650
    in pathfinder_lib::p2p_network::behaviour
    in pathfinder_lib::p2p_network::p2p

  2024-11-09T09:23:39 ERROR pathfinder: Sync process ended unexpected with: Err(No transactions)
    at crates/pathfinder/src/bin/pathfinder/main.rs:313

We do know which peer failed to provide the data although we don't know at which height.

@CHr15F0x CHr15F0x removed their assignment Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants