Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC refactor follow-up #2220

Open
2 of 5 tasks
sistemd opened this issue Sep 5, 2024 · 0 comments
Open
2 of 5 tasks

RPC refactor follow-up #2220

sistemd opened this issue Sep 5, 2024 · 0 comments
Assignees

Comments

@sistemd
Copy link
Contributor

sistemd commented Sep 5, 2024

  • Remove v06.
  • Don't use #[derive(serde::Deserialize)] and #[derive(serde::Serialize)] (except for types that are encoded into JSON strings in responses - CairoContractClass, maybe some others, there are comments indicating where this is the case).
  • Remove v02 and move the types into more reasonable locations.
  • Revisit deserialize_serde calls (almost all should be removed, except those used for types in point 2 above).
  • Move SerializeForVersion into the super module so it can be implemented on common types #2181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants