Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷🐛 Fix github actions: publish lab-react, publish data-grid-react #3073

Closed
oddvernes opened this issue Sep 26, 2023 · 8 comments
Closed
Assignees
Labels
🐛 bug Something isn't working

Comments

@oddvernes
Copy link
Collaborator

For some reason lab and data-grid are not found in the building packages step

eds@ build:data-grid-react /home/runner/work/design-system/design-system
pnpm --filter ./packages/eds-data-grid-react run build

No projects matched the filters in "/home/runner/work/design-system/design-system"

eds@ build:lab /home/runner/work/design-system/design-system
pnpm --filter @equinor/eds-lab-react run build

No projects matched the filters in "/home/runner/work/design-system/design-system"

I'm wondering if it has anything to do with the "dist cache" step, it says
cache not found for input keys: 799bc25bbeb95d221eb91c058036ad161d711c93-dist--data-grid

these same packages are found and built in the "checks" action but that does not have the "dist cache" step in "process packages"

@oddvernes oddvernes added the 🐛 bug Something isn't working label Sep 26, 2023
@oddvernes
Copy link
Collaborator Author

It looks like adding --force to pnpm m i --force in the install-dependencies step of _setup.yml fixed it. Not sure if this is ideal to do in the CI though 🤷‍♂

@oddvernes oddvernes self-assigned this Oct 4, 2023
@oddvernes oddvernes reopened this Oct 31, 2023
@oddvernes
Copy link
Collaborator Author

Publishing lab did not work last time again so reopening this issue

@oddvernes
Copy link
Collaborator Author

related to #3052

@BirteThornquist
Copy link
Contributor

Check if we should change to NPM(node package manager).

@oddvernes oddvernes removed their assignment Jan 17, 2024
@oddvernes
Copy link
Collaborator Author

oddvernes commented Feb 6, 2024

I was able to publish data-grid-react last week using github actions 🤷 Lets see next release if it has just randomly started working again (gh actions or "ubuntu-latest" changed?)

@oddvernes
Copy link
Collaborator Author

Update: publishing data-grid works fine, publishing lab fails

@torleifhalseth torleifhalseth self-assigned this Mar 8, 2024
@torleifhalseth
Copy link
Collaborator

Looked at this with @oddvernes after updating workspace file in #3339 . The GitHub action is now running build of all packages as expected.

@oddvernes
Copy link
Collaborator Author

Addendum: the real reason was our sparse checkout for each action which then got cached and reused in another action where other required packages was then not included. This was fixed by checking out all packages in all actions in 7f5ba6b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants