diff --git a/packages/eds-data-grid-react/src/EdsDataGrid.stories.tsx b/packages/eds-data-grid-react/src/EdsDataGrid.stories.tsx index 74907374ae..da808b9c72 100644 --- a/packages/eds-data-grid-react/src/EdsDataGrid.stories.tsx +++ b/packages/eds-data-grid-react/src/EdsDataGrid.stories.tsx @@ -374,7 +374,7 @@ export const Virtualization: StoryFn> = (args) => { Virtualization.args = { stickyHeader: true, enableVirtual: true, - virtualHeight: 500, + height: 500, } export const ExpandRows: StoryFn> = (args) => { @@ -423,7 +423,7 @@ export const ExpandRows: StoryFn> = (args) => { ExpandRows.args = { stickyHeader: true, enableVirtual: true, - virtualHeight: 500, + height: 500, } export const Styling: StoryFn> = (args) => { diff --git a/packages/eds-data-grid-react/src/EdsDataGrid.tsx b/packages/eds-data-grid-react/src/EdsDataGrid.tsx index 90b0669d90..30f23db01a 100644 --- a/packages/eds-data-grid-react/src/EdsDataGrid.tsx +++ b/packages/eds-data-grid-react/src/EdsDataGrid.tsx @@ -97,6 +97,14 @@ export function EdsDataGrid({ pageSize: pageSize ?? 25, }) + useEffect(() => { + if (virtualHeight) { + console.warn( + `virtualHeight prop is deprecated and will be removed in a later version. Please update your code to use height instead.`, + ) + } + }, [virtualHeight]) + useEffect(() => { setVisible(columnVisibility ?? {}) }, [columnVisibility, setVisible]) diff --git a/packages/eds-data-grid-react/src/EdsDataGridProps.ts b/packages/eds-data-grid-react/src/EdsDataGridProps.ts index 1beaa5adb3..0da9d16d37 100644 --- a/packages/eds-data-grid-react/src/EdsDataGridProps.ts +++ b/packages/eds-data-grid-react/src/EdsDataGridProps.ts @@ -177,6 +177,7 @@ type VirtualProps = { enableVirtual?: boolean /** * The height of the virtualized table in pixels. + * @deprecated Use `height` prop over virtualHeight, this will be removed in a later version * @default 500 */ virtualHeight?: number