Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tw theme for in config #2583

Open
BorghildSelle opened this issue Oct 21, 2024 · 1 comment · May be fixed by #2805
Open

Use tw theme for in config #2583

BorghildSelle opened this issue Oct 21, 2024 · 1 comment · May be fixed by #2805
Assignees
@VarunVAshrit
Labels
🛠 Technical Technical stuffs like reducing debt, refactor or improve code base

Comments

@BorghildSelle
Copy link
Contributor

BorghildSelle commented Oct 21, 2024 •
edited
Loading 

      maxWidth: {
        menuText: 'calc(35 * var(--space-medium))',
      },
  • change var(--space-medium) to theme(spacing.6)

In tailwind.css

  /* Image carousel card withs */
  --image-carousel-card-w-sm: 275px;
  --image-carousel-card-w-md: 692px;
  --image-carousel-card-w-lg: 980px;

change these to spacing variables like card-maxWidth in #2576 and use similar to max-w-card-maxWidth
@BorghildSelle BorghildSelle added the 🛠 Technical Technical stuffs like reducing debt, refactor or improve code base label Oct 23, 2024
@VarunVAshrit VarunVAshrit self-assigned this Jan 29, 2025
VarunVAshrit added a commit that referenced this issue Feb 4, 2025
@VarunVAshrit
Use tw theme for in config #2583
24e9291
@VarunVAshrit VarunVAshrit linked a pull request Feb 5, 2025 that will close this issue
Use tw theme for in config #2583 #2805
Open
@BorghildSelle BorghildSelle linked a pull request Feb 6, 2025 that will close this issue
Open
@BorghildSelle
Copy link
Contributor Author

@VarunVAshrit Forgot to tell you that changing them the image card carousel env the use of the must be updated to, where they are used.
so
w-[var(--image-carousel-card-w-sm)] md:w-[var(--image-carousel-card-w-md)]
to
w-image-carousel-card-w-sm md:w-image-carousel-card-w-md

VarunVAshrit added a commit that referenced this issue Feb 7, 2025
@VarunVAshrit
Updated image card carousel env and updated where they are used as well
382d216 
#2583
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VarunVAshrit VarunVAshrit

Labels
🛠 Technical Technical stuffs like reducing debt, refactor or improve code base
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use tw theme for in config #2583 equinor/energyvision
2 participants
@BorghildSelle @VarunVAshrit