Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow third coordinate in release name #96

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andreas-el
Copy link
Collaborator

@andreas-el andreas-el commented Feb 20, 2025

Issue
Resolves #95

Pick up optional custom coordinates from the enable-scripts.
They have similar syntax and contain the necessary information to find the correct release.

Tested on the numpy release after changing the komodoenv.conf file accordingly.

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@andreas-el andreas-el force-pushed the allow_three_coordinates_in_komodoenv branch 2 times, most recently from bffa59b to 759d3c3 Compare February 21, 2025 12:26
@andreas-el andreas-el self-assigned this Feb 21, 2025
@andreas-el andreas-el force-pushed the allow_three_coordinates_in_komodoenv branch from 759d3c3 to f1010a7 Compare February 21, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Komodoenv cant detect the release type from three coordinates
1 participant