Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTORING]: groupTreeAssembler.js in GroupTreePlot #1829

Closed
rubenthoms opened this issue Dec 12, 2023 · 6 comments · Fixed by #2367
Closed

[REFACTORING]: groupTreeAssembler.js in GroupTreePlot #1829

rubenthoms opened this issue Dec 12, 2023 · 6 comments · Fixed by #2367
Assignees
@Anders2303 @rubenthoms
Labels
bug Something isn't working CeeSol Task owned by Ceetron Solutions group-tree released

Comments

@rubenthoms
Copy link
Collaborator

rubenthoms commented Dec 12, 2023 •
edited
Loading

The drawing class in groupTreeAssembler.js utilized in GroupTreePlot does not support resizing. It does only use the initial width and height of the element it is rendered in and does not adjust to changes of the parent element. This can lead to bad UX, especially in the dynamic new Webviz application.

Recording 2023-12-12 111231 (1)

In addition, the class' code is difficult to adjust and maintain since it is written in plain JavaScript.

I suggest to:

  • Completely refactor/rewrite the drawing class in TypeScript
  • Add support for resizing
@rubenthoms rubenthoms self-assigned this Dec 12, 2023
@rubenthoms rubenthoms added bug Something isn't working CeeSol Task owned by Ceetron Solutions group-tree labels Dec 12, 2023
@jorgenherje
Copy link
Collaborator

jorgenherje commented Dec 12, 2023 •
edited
Loading

When performing the initial splitting, I started looking into converting grup_tree.js to typescript. This work can pinpoint some of the issues detected when trying to purely convert the .js implementation into .ts. E.g. the existing .js code directly manipulates d3 objects used, by adding new attributes etc in code. This is not allowed when using typescript.

Here is the testing branch: https://github.com/CeetronSolutions/webviz-subsurface-components/tree/split-group-tree-setting-and-view-ts-conversion-backup

Initial converting GroupTree.ts: https://github.com/CeetronSolutions/webviz-subsurface-components/blob/split-group-tree-setting-and-view-ts-conversion-backup/typescript/packages/group-tree/src/components/group-tree-plot/src/Plot/GroupTree.ts

@rubenthoms rubenthoms mentioned this issue Dec 12, 2023
Merged
@Anders2303 Anders2303 self-assigned this Nov 4, 2024
@Anders2303 Anders2303 mentioned this issue Nov 14, 2024
Merged
hkfb pushed a commit that referenced this issue Feb 3, 2025
@semantic-release-bot
chore(release): wsc-common@1.1.0 [skip ci]
e66712e 
# [1.1.0](https://github.com/equinor/webviz-subsurface-components/compare/wsc-common@1.0.15...wsc-common@1.1.0) (2025-02-03)

### Features

* GroupTreePlot --- Refactor to typescript + better D3 and React integration + some small features ([#2367](#2367)) ([a7cfab2](a7cfab2)), closes [#1829](#1829)
@hkfb
Copy link
Collaborator

hkfb commented Feb 3, 2025

🎉 This issue has been resolved in version wsc-common@1.1.0 🎉

The release is available on GitHub release

@hkfb hkfb added the released label Feb 3, 2025
hkfb pushed a commit that referenced this issue Feb 3, 2025
@semantic-release-bot
chore(release): group-tree-plot@1.4.0 [skip ci]
960f9cc 
# [1.4.0](https://github.com/equinor/webviz-subsurface-components/compare/group-tree-plot@1.3.24...group-tree-plot@1.4.0) (2025-02-03)

### Features

* GroupTreePlot --- Refactor to typescript + better D3 and React integration + some small features ([#2367](#2367)) ([a7cfab2](a7cfab2)), closes [#1829](#1829)
@hkfb
Copy link
Collaborator

hkfb commented Feb 3, 2025

🎉 This issue has been resolved in version group-tree-plot@1.4.0 🎉

The release is available on GitHub release

hkfb pushed a commit that referenced this issue Feb 3, 2025
@semantic-release-bot
chore(release): well-completions-plot@1.6.0 [skip ci]
128a3f0 
# [1.6.0](https://github.com/equinor/webviz-subsurface-components/compare/well-completions-plot@1.5.20...well-completions-plot@1.6.0) (2025-02-03)

### Features

* GroupTreePlot --- Refactor to typescript + better D3 and React integration + some small features ([#2367](#2367)) ([a7cfab2](a7cfab2)), closes [#1829](#1829)
@hkfb
Copy link
Collaborator

hkfb commented Feb 3, 2025

🎉 This issue has been resolved in version well-completions-plot@1.6.0 🎉

The release is available on GitHub release

hkfb pushed a commit that referenced this issue Feb 3, 2025
@semantic-release-bot
chore(release): subsurface-viewer@1.8.0 [skip ci]
be2e5e9 
# [1.8.0](https://github.com/equinor/webviz-subsurface-components/compare/subsurface-viewer@1.7.0...subsurface-viewer@1.8.0) (2025-02-03)

### Features

* GroupTreePlot --- Refactor to typescript + better D3 and React integration + some small features ([#2367](#2367)) ([a7cfab2](a7cfab2)), closes [#1829](#1829)
@hkfb
Copy link
Collaborator

hkfb commented Feb 3, 2025

🎉 This issue has been resolved in version subsurface-viewer@1.8.0 🎉

The release is available on GitHub release

hkfb pushed a commit that referenced this issue Feb 3, 2025
@semantic-release-bot
chore(release): well-log-viewer@2.3.0 [skip ci]
5b4f732 
# [2.3.0](https://github.com/equinor/webviz-subsurface-components/compare/well-log-viewer@2.2.6...well-log-viewer@2.3.0) (2025-02-03)

### Features

* GroupTreePlot --- Refactor to typescript + better D3 and React integration + some small features ([#2367](#2367)) ([a7cfab2](a7cfab2)), closes [#1829](#1829)
@hkfb
Copy link
Collaborator

hkfb commented Feb 3, 2025

🎉 This issue has been resolved in version well-log-viewer@2.3.0 🎉

The release is available on GitHub release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Anders2303 Anders2303

@rubenthoms rubenthoms

Labels
bug Something isn't working CeeSol Task owned by Ceetron Solutions group-tree released
Projects
None yet
Milestone
No milestone
4 participants
@hkfb @Anders2303 @rubenthoms @jorgenherje