Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump @equinor/eds-core-react in /typescript #2429

Open
w1nklr opened this issue Jan 30, 2025 · 1 comment
Open

bump @equinor/eds-core-react in /typescript #2429

w1nklr opened this issue Jan 30, 2025 · 1 comment

Comments

@w1nklr
Copy link
Collaborator

w1nklr commented Jan 30, 2025

Bumping @equinor/eds-core-react in /typescript fails.

Unit tests and smoke tests are failing. Snapshots from #2381 :

Image

@rubenthoms
Copy link
Collaborator

rubenthoms commented Jan 30, 2025

@w1nklr I started investigating the issue and I managed to identify what is wrong.
@equinor/eds-core-react changed from a portal implementation to the native HTML Popover API (which is relatively new, but supported in all major browsers now):

https://github.com/equinor/design-system/releases/tag/eds-core-react%400.41.3

The Popover API, however, is not supported by jsdom yet (jsdom/jsdom#3721). That is why we got all these errors with undefined functions. This problem can be fixed by mocking the two methods showPopover and hidePopover.

However, there are some failing tests remaining. From what I have seen so far, they are all checking if the popover elements are visible and that doesn't seem to work. I haven't had the time yet to investigate further, maybe we can adjust the tests. Alternatively, we could also disable them or pin the @equinor/eds-core-react version to <0.41.3 until jsdom supports popovers.

I opened a draft PR here: #2431

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants