-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IIAs in index but deliberately not returned with get-response (to avoid und as language) #178
Comments
These IIAs are not mutually approved, not even matched. They do not have languages filled in and University of Warsaw should not make them visible in the EWP network. Because they are visible but languages are missing the system does not allow to send them via the network but generates 500. If they would be mutually approved but languages would be missing, they would have been sent with not-yet-defined and some language (not UND). |
You are defining your own rules. If IIA ID is there in the index endpoint, you must not respond with 500 for IIA GET. If you think IIA is not appropriate to be shared then you must not put it in the index endpoint response. There is no confusion about it. At this point I must ask, are you working for EWP project under DG EAC, or are you working for University of Warsaw implementation? |
Probably you are putting hack in your system to mitigate the badly conceived API specification about deleted IIAs. |
I'll try to make it as simple as I can. USOS/MUCI provides software, that is being installed on HEIs. We do not own their data, we do not have access to their data. There were several points to get us where we are now. Several meetings, several new versions of software, one month of collecting the data about approved IIAs, so HEIs can switch to IIA 7.0. What is happening here is that UW decides that they want all old agreements to be visible in EWP, even if they were approved only on paper. They bypass our scripts and our software and change the database data directly. Without looking on consequences. Now the only thing that we can do was: hide this behind their back (hide it on index) or be open about what is happening so that is someone will start making call for those IIAs both sides will see the problem and, hopefully, the problem will be fixed ASAP. As a side note, to be fair, it was my call, @janinamincer-daszkiewicz was against it. I don't like to hide problems. We're catching them on stats portal and contacting HEIs, so they can fixed something that they have more than 6 months to do. This is all we can do, ask. As I said, we do not have access to HEIs data. PS. This was months before UND and yet another shitstorm on github. |
Hi @Emkas As I understand from your response, some data in UW DB is bad/wrong. Even then, you must provide IIA details in the GET response. The partner will check and report about the wrong data. |
Better implementation will automatically from clear and better specs. And better specs will only come with open thought process. Not by limiting ourselves to knowledge of how few systems work and certainly not be quoting "Implementation is as per requirement from DG EAC". |
if we all respect the specification and not introduce own rules. |
Do you think is correct that? |
That's right. Maybe what is missing here is that this case is one-time problem. What I mean by that, is that for all new agreements this won't take place. This was a part of transition from v6 to v7.
Well, the second part is the point of it. So that IRO's will contact each other, as their are doing already and say, something is wrong in your data, check it.
About hack... Well, I'd call that this is an honest solution. I'd call a hack 500 without any information, and pretend that "someone is looking what is goin' on". As I know that some (rather smaller) parties are doing. But I don't what to be the sheriff on this network. I don't have time for this. For me EWP is less than 1% of our software which generate more than 50% of problems on our issue tracker. |
A bit funny that you leave it to smarter parties to draft specification but still come up with your own interpretation and hack. I hope there is someone from your team who represent those parties. You have assumed that every system will have implementation to show the message to the IROs that you pass along 500 response. 500 means its a server error which will is temporary and most likely get corrected on its own. |
@Emkas no one is pointing on you 😊 but as you said :
probably we all must do the same because the final result it is worst then the problem. |
I cannot add any more to what @umesh-qs and @skishk have said. As concern the reference implementation, I said "almost"; we can use the expression "golden implementation" or similar, but I think it would be very difficult to suppose something different, when we know that Janina is participating in USOS project (since 1999) and at the same time she is the maintainer of the EWP project. |
@umesh-qs I don't understand why we have discussed about the deletion and the possibility that an IIA appears again in the network. |
That is why I called it a hack in my other comments. And EWP consortia member giving green signal to it means we can now create new use cases with it. |
Your answer is dated 26 July. MobilityOnLine only 8 times: https://stats.erasmuswithoutpaper.eu/monitoring/?group_by=&date_from=2024-07-26&server_message=+language&http_code=500&server_provider=mobility&sort_by=-timestamp Your solution has been used only by MUCI (USOS), or you have imposed the solution used by MUCI (USOS), doesn't make a great difference. |
We've just entered into production and we are doing some explorations.
As first try, we called IIA Index from uw.edu.pl (I mention them because they should be almost the reference implementations).
We received 4 IIAs, but only one can be read.
For the others we receive an HTTP 500 error and a developer error message that says:
Developer Error Message: No outgoing languages for cooperation: 17544
Developer Error Message: No outgoing languages for cooperation: 19273
Developer Error Message: No outgoing languages for cooperation: 19479
I think this is the solution adopted by USOS as suggested by @janinamincer-daszkiewicz to avoid to use UND (undefined) together with not-yet-defined, that they limited to the mutual approved IIAs in v6 (and I don't understand why).
@janinamincer-daszkiewicz seemed to be satisfied with this solution, but now that I understand what she meant and how they implement the solution, I think I can say that it's illegal and it infringes a basic rule:
Indeed, the presence of a developer message means that the partner deliberately forbids us to read the IIAs that are listed in the Index, and this is not allowed by the rules.
I hope you realize that you encouraged to infringe old and commonly accepted rules just to avoid the use of the UND as language code and the not-yet-defined attribute for not mutually approved IIAs
The text was updated successfully, but these errors were encountered: