Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Irregular use of F() macro. #41

Open
H3wastooshort opened this issue Aug 26, 2021 · 0 comments
Open

Irregular use of F() macro. #41

H3wastooshort opened this issue Aug 26, 2021 · 0 comments

Comments

@H3wastooshort
Copy link

H3wastooshort commented Aug 26, 2021

The F() macro is used only sometimes. The RAM load would be decreased if it were to be used more regularly.

Example:

String GSMSimTime::syncFromServer() {
	gsm.print("AT+CNTPCID=1\r"); //Bad
	_readSerial();

	gsm.print(F("AT+CNTP\r")); //Good
	_readSerial();
	//delay(50);
	_readSerial(30000);

Was it just forgotten, or is there something preventing it's use?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant