You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I ran the latest version of this code against the included unit tests and found that a number of them are failing. Just raising awareness in case this is unintentional.
I only coded the test to check the title, so other props (even in successful tests), may or may not be correct.
expected vs actual:
#14 MISMATCH: Juuni Kokki => (Les 12 Royaumes)
#39 MISMATCH: Kiddy Grade 2 => Kiddy Grade
#64 MISMATCH: Keroro => 148
#78 MISMATCH: Aim For The Top! Gunbuster => Aim For The Top! Gunbuster-ep1
#81 MISMATCH: Mobile Suit Gundam Seed Destiny => encoded by SEED
#82 MISMATCH: ?K? => Image
#98 MISMATCH: Golden Time => ?
#101 MISMATCH: Mangaka-san to Assistant-san to the Animation => 02
#103 MISMATCH: Rozen Maiden 3 => Rozen Maiden
#112 MISMATCH: Death Note => 37 [Ruberia] Death Note
#113 MISMATCH: Accel World - EX => Accel World - EX01
#120 MISMATCH: Akuma no Riddle => EvoBot [Watakushi] Akuma no Riddle
#121 MISMATCH: => 01 - Land of Visible Pain
#124 MISMATCH: The iDOLM@STER 765 Pro to Iu Monogatari => The iDOLM@STER
#129 MISMATCH: Hidamari Sketch x365 => Hidamari Sketch x365 - 04.1
#130 MISMATCH: => The Boy in the Iceberg
#138 MISMATCH: The Animatrix => The Animatrix 08.A Detective Story
#144 MISMATCH: Memories Off 3.5 => Memories Off
#146 MISMATCH: Byousoku 5 Centimeter => Byousoku
The text was updated successfully, but these errors were encountered:
Thanks for the heads up, but the errors are intentional. Some filenames in data.json are almost impossible to parse correctly (at least without a trade off), while some others are parsed incorrectly but can be ignored. I added them just so that I don't forget these kinds of edge cases exists.
I should probably mark these filenames as such and commit my own test code (see this comment for more information) sometime.
Hello,
I ran the latest version of this code against the included unit tests and found that a number of them are failing. Just raising awareness in case this is unintentional.
I only coded the test to check the title, so other props (even in successful tests), may or may not be correct.
expected vs actual:
The text was updated successfully, but these errors were encountered: