Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

abstract Doctrine entities should not require final methods #295

Open
localheinz opened this issue Oct 30, 2020 · 7 comments · May be fixed by #396
Open

abstract Doctrine entities should not require final methods #295

localheinz opened this issue Oct 30, 2020 · 7 comments · May be fixed by #396
Assignees
@localheinz
Labels
bug

Comments

@localheinz
Copy link
Member

abstract Doctrine entities should not require final methods.

final methods will not work here because proxies will want to override them.

/cc @OskarStark
@localheinz localheinz added the bug label Oct 30, 2020
@localheinz localheinz mentioned this issue Oct 30, 2020
Closed
@ergebnis-bot
Copy link
Member

Since this issue has not had any activity within the last 180 days, I have marked it as stale.

I will close it if no further activity occurs within the next 14 days.

@OskarStark
Copy link

Shall we keep this open @localheinz ?

@ergebnis-bot
Copy link
Member

Since this issue has not had any activity within the last 180 days, I have marked it as stale.

I will close it if no further activity occurs within the next 14 days.

@localheinz localheinz self-assigned this Nov 8, 2021
@localheinz localheinz removed the stale label Nov 8, 2021
@localheinz localheinz changed the title Abstract Doctrine entities should not require final methods abstract Doctrine entities should not require final methods Nov 8, 2021
@localheinz localheinz linked a pull request Nov 8, 2021 that will close this issue
Draft
1 task
@ergebnis-bot
Copy link
Member

Since this issue has not had any activity within the last 180 days, I have marked it as stale.

I will close it if no further activity occurs within the next 14 days.

@OskarStark
Copy link

As there is an open PR already let's keep it open please

@localheinz localheinz removed the stale label May 8, 2022
@ergebnis-bot
Copy link
Member

Since this issue has not had any activity within the last 180 days, I have marked it as stale.

I will close it if no further activity occurs within the next 14 days.

@OskarStark
Copy link

Keep it open please

@ergebnis-bot ergebnis-bot removed the stale label Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@localheinz localheinz

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Adjust Methods\FinalInAbstractClassRule to ignore Doctrine entities ergebnis/phpstan-rules
3 participants
@localheinz @OskarStark @ergebnis-bot