Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet rescan from a given height rather than from beginning #1256

Closed
scalahub opened this issue Dec 27, 2020 · 5 comments
Closed

Wallet rescan from a given height rather than from beginning #1256

scalahub opened this issue Dec 27, 2020 · 5 comments
Labels
B-500 SigUSD bounty C-enhancement Category: A PR with an enhancement or a proposed one in an issue.

Comments

@scalahub
Copy link
Collaborator

It will be preferable if we can ask the node to rescan blockchain and the wallet from some given height instead of from the beginning.
Many dApps rely on recently issued transactions so it is often wasteful to rescan the entire blockchain

@scalahub scalahub added the C-enhancement Category: A PR with an enhancement or a proposed one in an issue. label Dec 27, 2020
@kushti kushti changed the title Allow rescanning from a given height rather than from beginning Wallet rescan from a given height rather than from beginning Nov 10, 2021
@glasgowm148 glasgowm148 added this to the low-priority-tasks milestone Feb 2, 2022
@greenhat
Copy link
Member

greenhat commented Mar 20, 2023

Oracle-core would very much appreciate this feature implemented. It'd minimize pool downtime on update significantly. See ergoplatform/oracle-core#242 for details.

@kushti
Copy link
Member

kushti commented Mar 24, 2023

Oracle-core would very much appreciate this feature implemented. It'd minimize pool downtime on update significantly. See ergoplatform/oracle-core#242 for details.

It is implemented long time ago, anything needed?

@greenhat
Copy link
Member

Oracle-core would very much appreciate this feature implemented. It'd minimize pool downtime on update significantly. See ergoplatform/oracle-core#242 for details.

It is implemented long time ago, anything needed?

Oh, right. My bad. I forgot that this feature exists. We even used it initially but we had to disable it because the wallet does not see anything below the given height, including the user's coins. Is it intended to work this way?

@kushti
Copy link
Member

kushti commented Mar 24, 2023

Oracle-core would very much appreciate this feature implemented. It'd minimize pool downtime on update significantly. See ergoplatform/oracle-core#242 for details.

It is implemented long time ago, anything needed?

Oh, right. My bad. I forgot that this feature exists. We even used it initially but we had to disable it because the wallet does not see anything below the given height, including the user's coins. Is it intended to work this way?

well, yes, no efficient way to find what was before beginning of a scan without scanning

@kushti kushti closed this as completed Mar 24, 2023
@pragmaxim
Copy link
Collaborator

There is a related PR #1723

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-500 SigUSD bounty C-enhancement Category: A PR with an enhancement or a proposed one in an issue.
Projects
None yet
Development

No branches or pull requests

5 participants