Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example usage removes const from string literal for no reason #7

Open
tomalakgeretkal opened this issue May 31, 2019 · 0 comments
Open

Example usage removes const from string literal for no reason #7

tomalakgeretkal opened this issue May 31, 2019 · 0 comments

Comments

@tomalakgeretkal
Copy link

Usage example casts string literal to char*, which is not a good thing to do (there is a reason we have const char* here!).

It's needless anyway because Lookup takes const char* so you're only adding the const back again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomalakgeretkal