Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect Logging Secrets #59

Open
eric-volz opened this issue Nov 17, 2022 · 1 comment
Open

Protect Logging Secrets #59

eric-volz opened this issue Nov 17, 2022 · 1 comment
Assignees
@eric-volz
Labels
area:package Python Package package:node Python Package Node / RPC API package:ocean Python Package Ocean API package:transactions Python Package Transactions SDK

Comments

@eric-volz
Copy link
Owner

What would you like to be added:

Protect sensitive information during logging

Why is this needed:

The logging file is a pure text file. If secrets are logged, everyone can see them if they have access to the log file.

How to implement:

  • Adding a new boolean parameter to the Logging class: protected: bool = True
  • if this parameter is True and if a method is used that has to be protected the secrets in this request get filtered
@eric-volz eric-volz added the improvement What can be improved? label Nov 17, 2022
@eric-volz eric-volz changed the title Protect loggig secrets IMPROVE: Protect loggig secrets Nov 17, 2022
@eric-volz eric-volz added area:package Python Package package:node Python Package Node / RPC API package:ocean Python Package Ocean API package:transactions Python Package Transactions SDK and removed improvement What can be improved? labels Aug 2, 2023
@eric-volz eric-volz self-assigned this Aug 2, 2023
@eric-volz eric-volz moved this to Backlog in DefichainPython Aug 2, 2023
@eric-volz
Copy link
Owner Author

Logging will get reworked when v3.0.0 is released

@eric-volz eric-volz changed the title IMPROVE: Protect loggig secrets Protect Logging Secrets Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eric-volz eric-volz

Labels
area:package Python Package package:node Python Package Node / RPC API package:ocean Python Package Ocean API package:transactions Python Package Transactions SDK
Projects
DefichainPython
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eric-volz