Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop CommonJS support #1877

Open
ericcornelissen opened this issue Feb 12, 2025 · 0 comments
Open

Drop CommonJS support #1877

ericcornelissen opened this issue Feb 12, 2025 · 0 comments
Labels
breaking change Changes that are not backwards compatible pending This cannot be worked on yet

Comments

@ericcornelissen
Copy link
Owner

Inspired by https://antfu.me/posts/move-on-to-esm-only

Summary

Drop support for CommonJS by removing the transpiration from ESM to CJS, removing the .d.cts files, removing CJS tests, etc.

The motivation for this is to simplify the project, supported by the arguments laid out in https://antfu.me/posts/move-on-to-esm-only.

In any case, this is a breaking change for v2 of this package, and hence cannot be realized until the release of v3. This is because CommonJS support is currently supported and the package declares support for Node.js releases that don't support the new CJS-imports-ESM functionality.

@ericcornelissen ericcornelissen added breaking change Changes that are not backwards compatible pending This cannot be worked on yet labels Feb 12, 2025
@ericcornelissen ericcornelissen changed the title Drop CommonJS supper Drop CommonJS support Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Changes that are not backwards compatible pending This cannot be worked on yet
Projects
None yet
Development

No branches or pull requests

1 participant