-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
中文导致arc diff --update DXX 无法执行原有操作 #6
Comments
汉化未涉及 arcanist。只是针对 phabricator 进行的。不知道您是把汉化文件拷贝到哪里了导致 arcanist 也被汉化了? |
@arielyang 我如果在phabricator上选择中文,arcanist也会出现中文,比如在arc diff审核单,选择英文的时候这些也会变成英文, 难道arcanist也会拉phabricator的字典? |
arcanist 您操作是在本地做的吧,Phabricator 应该是跑在服务端,所以汉化应该在服务端发生的?为什么本地会变成中文? |
谢谢指出问题。
public function getFieldName() {
return pht('Differential Revision');
} 修改为: public function getFieldName() {
return 'Differential Revision';
} 此处的 Differential Revision 不再被翻译,但每次升级的时候需要重新修改。 |
已经临时去掉了 Differential Revision 的翻译。后续给官方提一个 commit 来 fix 这个 bug。 |
使用汉化包后,导致arc diff --update DXX无法更新DXX,而会创建一个新的revision,可能汉化后无法与源代码中文本检测相对应
参考1:https://github.com/phacility/arcanist/blob/9e82ef979e8148c43b9b8439025d505b1219e213/src/differential/ArcanistDifferentialCommitMessage.php#L104
参考2:https://discourse.phabricator-community.org/t/arc-diff-keeps-creating-new-revision-on-phabricator/409/4
The text was updated successfully, but these errors were encountered: